Add google drive sync script #68

Vylpes · 2023-10-25T14:43:40+01:00

Vylpes commented

2023-10-25 14:43:40 +01:00

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Add Google Drive Sync script
Add web hook to allow external scripts to trigger a card database reload

NOTE: This requires extra work once merged, need to implement the cron job for the script on the server

#35

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

This can't really be tested until its in the stage server, as it requires a server cron job setup
Have tested the web hook locally with curl and that part works

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Add Google Drive Sync script - Add web hook to allow external scripts to trigger a card database reload > **NOTE:** This requires extra work once merged, need to implement the cron job for the script on the server #35 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - This can't really be tested until its in the stage server, as it requires a server cron job setup - Have tested the web hook locally with `curl` and that part works # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 1 commit 2023-10-25 14:43:41 +01:00

Add reload db webhook

continuous-integration/drone/push Build is passing

Details

adbfbd5cde

Vylpes requested review from VylpesTester 2023-10-25 14:43:46 +01:00

Vylpes added the

type

story

label 2023-10-25 14:43:50 +01:00

Vylpes added this to the 0.2.0 milestone 2023-10-25 14:43:52 +01:00

VylpesTester was assigned by Vylpes

2023-10-25 14:43:55 +01:00

VylpesTester requested changes 2023-10-27 15:58:57 +01:00

.prod.env Outdated

					
				@ -29,2 +29,4 @@

				DB_CARD_FILE=:memory:

				EXPRESS_PORT=3303

VylpesTester commented

2023-10-27 15:57:07 +01:00

This should be 3323

This should be `3323`

Vylpes marked this conversation as resolved

src/webhooks.ts

					
				@ -0,0 +7,4 @@

				    private port = process.env.EXPRESS_PORT!;

				    public start() {

VylpesTester commented

2023-10-27 15:58:43 +01:00

These could be static

Vylpes commented

2023-11-01 18:07:22 +00:00

Actually, we can't make it static as we use it from a non-static function, we'd want to keep this so the web hooks are associated with each client instance

VylpesTester marked this conversation as resolved

VylpesTester added spent time 2023-10-27 15:59:01 +01:00

5 minutes

Vylpes added 1 commit 2023-11-01 18:07:51 +00:00

Fix changes requested

continuous-integration/drone/push Build is passing

Details

fa0ee35b42

Vylpes requested review from VylpesTester 2023-11-01 18:08:15 +00:00

VylpesTester approved these changes 2023-11-03 19:35:22 +00:00

VylpesTester added spent time 2023-11-03 19:35:27 +00:00

5 minutes