Align docs/effects.md with dynamic unclaimed chance #528

New issue

Open

opened 2026-09-15 12:26:12 +01:00 by Smithy-bot · 0 comments

Smithy-bot commented

2026-09-15 12:26:12 +01:00

Member

Spun out of the non-blocking review note on PR #527.

Why

docs/effects.md still describes the unclaimed-card effect as a flat 50% chance. Runtime now scales the chance from pool completion using UnusedChanceUpMin / UnusedChanceUpMax (clamped between those bounds).

The docs should match the live behaviour so operators and contributors are not misled.

Suggested approach

Update the unclaimed-chance section in docs/effects.md to describe dynamic scaling based on how much of the card pool the user has claimed.
Document the min/max clamp (UnusedChanceUpMin / UnusedChanceUpMax) and give a short example (e.g. 65% unclaimed → 65% chance, within the configured bounds).
Remove or correct any remaining reference to a fixed 50% chance.

Notes

Source: #527 (comment)

Spun out of the non-blocking review note on PR #527. ## Why `docs/effects.md` still describes the unclaimed-card effect as a flat 50% chance. Runtime now scales the chance from pool completion using `UnusedChanceUpMin` / `UnusedChanceUpMax` (clamped between those bounds). The docs should match the live behaviour so operators and contributors are not misled. ## Suggested approach 1. Update the unclaimed-chance section in `docs/effects.md` to describe dynamic scaling based on how much of the card pool the user has claimed. 2. Document the min/max clamp (`UnusedChanceUpMin` / `UnusedChanceUpMax`) and give a short example (e.g. 65% unclaimed → 65% chance, within the configured bounds). 3. Remove or correct any remaining reference to a fixed 50% chance. ## Notes - Source: https://git.vylpes.xyz/External/card-drop/pulls/527#issuecomment-21271

Smithy-bot added the

labels

2026-09-15 12:26:12 +01:00

Smithy-bot self-assigned this

2026-09-15 12:26:12 +01:00