External/card-drop

Fork 0

Update the drop mechanic to take currency on drop instead of claim #428

Merged

Vylpes merged 9 commits from feature/CD-415 into develop

2025-05-16 17:37:58 +01:00

Vylpes commented

2025-04-04 19:05:45 +01:00

Owner

Description

Update the drop mechanic to take currency on drop instead of claim
Update the time until anyone can claim the card to 2 minutes
Remove the restriction that the last drop can only be claimed by the user who dropped it
- Now just controlled by the 2 minutes rule

#415

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description - Update the drop mechanic to take currency on drop instead of claim - Update the time until anyone can claim the card to 2 minutes - Remove the restriction that the last drop can only be claimed by the user who dropped it - Now just controlled by the 2 minutes rule #415 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 4 commits 2025-04-04 19:05:45 +01:00

Update drop mechanic to take currency on drop instead of claim f98f15b06a

Update the time until anyone can claim the card to 2 minutes aafcfd664a

Update PurgeClaims timer to purge after 2 minutes 2ab3ea1105

Remove restriction that the last drop can only be claimed by the user who dropped it

Test / build (push) Failing after 38s

Details

673f0d0810

Vylpes added the

type

story

label 2025-04-04 19:05:52 +01:00

Vylpes added 2 commits 2025-04-07 18:42:50 +01:00

Fix existing tests f9ab6c126e

Plan tests

Test / build (push) Failing after 40s

Details

f32a39331d

Vylpes added 3 commits 2025-04-24 19:56:10 +01:00

Merge branch 'develop' into feature/CD-415 01dec14b6c

Update yarn.lock 4ff8d15e2c

WIP: Start of drop command tests

Test / build (push) Failing after 46s

Details

78963d6b7c

Vylpes added 2 commits 2025-05-04 10:59:09 +01:00

Update tests fd803a0433

Fix linting

Test / build (push) Successful in 46s

Details

be712b08f4

Vylpes force-pushed feature/CD-415 from be712b08f4 to a29cd2ed20

2025-05-04 11:01:59 +01:00

Compare

Vylpes changed title from ~~WIP: Update the drop mechanic to take currency on drop instead of claim~~ to Update the drop mechanic to take currency on drop instead of claim

2025-05-04 11:03:00 +01:00