Command to allow the user to buy more effects #424

Merged
Vylpes merged 13 commits from feature/CD-381 into develop 2025-03-26 18:30:16 +00:00
Owner

Description

  • Create a command to generate an embed for the user to be able to buy more effects
  • This embed will contain the details about the effect as well as 2 buttons; Confirm and Cancel
  • The confirm button will call the button event to:
    • Remove the currency from the user
    • Give the user the effect to their inventory
  • The cancel button will just disable the buttons, so the user can't accidentally use it if they don't want to.

#381

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Have created unit tests and tested locally

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description - Create a command to generate an embed for the user to be able to buy more effects - This embed will contain the details about the effect as well as 2 buttons; Confirm and Cancel - The confirm button will call the button event to: - Remove the currency from the user - Give the user the effect to their inventory - The cancel button will just disable the buttons, so the user can't accidentally use it if they don't want to. #381 ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? - Have created unit tests and tested locally # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added the
type
story
label 2025-03-17 18:36:56 +00:00
Vylpes added 13 commits 2025-03-17 18:36:57 +00:00
Create /effects buy subcommand
Some checks failed
Test / build (push) Failing after 36s
904842ae32
WIP: Create buy embed generate helper function
Some checks failed
Test / build (push) Failing after 35s
b2807adf4d
WIP: Start creating buy subactions
Some checks failed
Test / build (push) Failing after 38s
d4c75845e5
WIP: Start creating tests for confirmation button event
Some checks failed
Test / build (push) Failing after 39s
f745fdfbca
WIP: Implement adding to the users inventory on confirm
Some checks failed
Test / build (push) Failing after 41s
1f5a19f101
Update tests
Some checks failed
Test / build (push) Failing after 42s
bc98d6ba75
Fix linting issue
All checks were successful
Test / build (push) Successful in 41s
a521ea193a
Vylpes requested review from Copilot 2025-03-17 18:38:52 +00:00
Copilot reviewed 2025-03-17 18:42:57 +00:00
Copilot left a comment
Member

Pull Request Overview

This PR adds a new command to allow users to buy more effects, including generating an interactive embed with Confirm and Cancel buttons. Key changes include:

  • Implementation of new "buy" functionality in both command and button event contexts.
  • Updates to helper functions (e.g. renaming GenerateEffectEmbed to GenerateEffectListEmbed and adding GenerateEffectBuyEmbed) to support effect purchasing.
  • Addition of tests to cover the new buy behavior along with minor adjustments in centralized command routing.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

## Pull Request Overview This PR adds a new command to allow users to buy more effects, including generating an interactive embed with Confirm and Cancel buttons. Key changes include: - Implementation of new "buy" functionality in both command and button event contexts. - Updates to helper functions (e.g. renaming GenerateEffectEmbed to GenerateEffectListEmbed and adding GenerateEffectBuyEmbed) to support effect purchasing. - Addition of tests to cover the new buy behavior along with minor adjustments in centralized command routing. ### Reviewed Changes Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Vylpes changed title from WIP: Command to allow the user to buy more effects to Command to allow the user to buy more effects 2025-03-17 18:43:13 +00:00
Vylpes requested review from VylpesTester 2025-03-17 18:43:16 +00:00
VylpesTester was assigned by Vylpes 2025-03-17 18:43:20 +00:00
VylpesTester approved these changes 2025-03-26 18:30:04 +00:00
Vylpes merged commit 5089ad6ab6 into develop 2025-03-26 18:30:16 +00:00
Vylpes deleted branch feature/CD-381 2025-03-26 18:30:16 +00:00
Sign in to join this conversation.
No description provided.