The issue body has no explicit acceptance criteria, so I used the GIVEN/WHEN/THEN unit tests written during implementation in PR #493 as the QA tests, plus a static trace of the flag through the call chain.

Pipeline (mirrors `.forgejo/workflows`)

Step	Result
`yarn install --frozen-lockfile`	pass
`yarn build` (tsc)	pass
`yarn lint` (eslint)	pass, 0 problems
`yarn test` (jest)	pass — 22/22 suites, 78 passed, 30 todo, 9 snapshots

Feature-specific tests

tests/commands/series.test.ts — 3/3 passed

GIVEN view command has disable_colour_filter=true, EXPECT helper called with true
GIVEN view command omits disable_colour_filter, EXPECT helper called with false
GIVEN list subcommand, EXPECT list page to be generated

tests/buttonEvents/Series.test.ts — 3/3 passed

GIVEN view customId contains filter flag, EXPECT helper called with true
GIVEN view customId omits filter flag, EXPECT helper called with false
GIVEN list customId, EXPECT list helper and interaction update

Behaviour verified

/series view registers the optional boolean option disable_colour_filter ("Show all cards in full colour"), defaulting to false when omitted, so existing behaviour is unchanged.
The flag flows from commands/series.ts into SeriesHelper.GenerateSeriesViewPage and on into ImageHelper.GenerateCardImageGrid, where the guard becomes userId != null && !disableColourFilter. With the flag set, the per-card Inventory.FetchOneByCardNumberAndUserId lookup and greyscale pass are skipped entirely — which is the performance win this issue asked for.
Pagination preserves the choice: the Previous/Next button customIds are suffixed with 1/0 and buttonEvents/Series.ts reads position 4 back, so paging through a series does not silently re-enable the filter.

Note for UAT

There is no test suite for ImageHelper in this repo (a pre-existing gap, not introduced here), so the greyscale skip itself is covered only by the static trace above and not by an automated assertion. Worth eyeballing a real /series view id:<n> disable_colour_filter:True in Discord during UAT to confirm unclaimed cards render in full colour and that the page loads noticeably faster.

Moving to step/uat.

## QA test results — PASS Tested `release/0.11.0` (head `0efae8b`, the merge of PR #493 which implemented this change). The issue body has no explicit acceptance criteria, so I used the GIVEN/WHEN/THEN unit tests written during implementation in PR #493 as the QA tests, plus a static trace of the flag through the call chain. ### Pipeline (mirrors `.forgejo/workflows`) | Step | Result | | --- | --- | | `yarn install --frozen-lockfile` | pass | | `yarn build` (tsc) | pass | | `yarn lint` (eslint) | pass, 0 problems | | `yarn test` (jest) | pass — 22/22 suites, 78 passed, 30 todo, 9 snapshots | ### Feature-specific tests `tests/commands/series.test.ts` — 3/3 passed - GIVEN view command has `disable_colour_filter=true`, EXPECT helper called with `true` - GIVEN view command omits `disable_colour_filter`, EXPECT helper called with `false` - GIVEN list subcommand, EXPECT list page to be generated `tests/buttonEvents/Series.test.ts` — 3/3 passed - GIVEN view customId contains filter flag, EXPECT helper called with `true` - GIVEN view customId omits filter flag, EXPECT helper called with `false` - GIVEN list customId, EXPECT list helper and interaction update ### Behaviour verified - `/series view` registers the optional boolean option `disable_colour_filter` ("Show all cards in full colour"), defaulting to `false` when omitted, so existing behaviour is unchanged. - The flag flows from `commands/series.ts` into `SeriesHelper.GenerateSeriesViewPage` and on into `ImageHelper.GenerateCardImageGrid`, where the guard becomes `userId != null && !disableColourFilter`. With the flag set, the per-card `Inventory.FetchOneByCardNumberAndUserId` lookup and greyscale pass are skipped entirely — which is the performance win this issue asked for. - Pagination preserves the choice: the Previous/Next button customIds are suffixed with `1`/`0` and `buttonEvents/Series.ts` reads position 4 back, so paging through a series does not silently re-enable the filter. ### Note for UAT There is no test suite for `ImageHelper` in this repo (a pre-existing gap, not introduced here), so the greyscale skip itself is covered only by the static trace above and not by an automated assertion. Worth eyeballing a real `/series view id:<n> disable_colour_filter:True` in Discord during UAT to confirm unclaimed cards render in full colour and that the page loads noticeably faster. Moving to `step/uat`.

Smithy-bot added

and removed

labels

2026-08-29 19:21:42 +01:00

Smithy-bot referenced this issue

2026-09-01 12:33:00 +01:00

2026 Code Clean Up #512

Smithy-bot referenced this issue