Add ability to view another's inventory #155

Merged
Vylpes merged 6 commits from feature/131-inventory-other into develop 2024-02-16 17:21:50 +00:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Add ability to view another user's inventory
  • Fix bug where the inventory generation logic was overriding the main array

#131, #138

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Add ability to view another user's inventory - Fix bug where the inventory generation logic was overriding the main array #131, #138 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 2 commits 2024-02-02 18:57:04 +00:00
Fix inventory overriding the main array
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
664d3d1888
Vylpes requested review from VylpesTester 2024-02-02 18:57:07 +00:00
Vylpes added the
type
story
label 2024-02-02 18:57:15 +00:00
VylpesTester was assigned by Vylpes 2024-02-02 18:57:21 +00:00
VylpesTester requested changes 2024-02-12 17:49:26 +00:00
@ -12,2 +20,4 @@
const embed = await InventoryHelper.GenerateInventoryPage(member.user.username, member.user.id, Number(page));
await interaction.update({
content: `${member.user.username} - ${member.user.id}`,
Member

This should be removed

This should be removed
Vylpes marked this conversation as resolved
VylpesTester added spent time 2024-02-12 17:49:31 +00:00
1 minute
Vylpes added 2 commits 2024-02-12 17:54:21 +00:00
Remove unnecessary content field in interaction update
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
8faacf2660
Vylpes requested review from VylpesTester 2024-02-12 17:55:06 +00:00
Vylpes added 2 commits 2024-02-14 10:36:23 +00:00
Remove user id content from inventory command used during testing
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
f168149c89
VylpesTester approved these changes 2024-02-16 17:21:23 +00:00
VylpesTester started working 2024-02-16 17:21:25 +00:00
VylpesTester canceled time tracking 2024-02-16 17:21:28 +00:00
VylpesTester added spent time 2024-02-16 17:21:32 +00:00
2 minutes
Vylpes merged commit 6ee8db6232 into develop 2024-02-16 17:21:50 +00:00
Vylpes deleted branch feature/131-inventory-other 2024-02-16 17:21:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 3 minutes
VylpesTester
3 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#155
No description provided.