External/card-drop
5
0
Fork 0
Code Issues 45 Pull requests Projects 1 Releases 28 Packages Wiki Activity Actions

AS a user, I want to be able to search for a card by its name #154

New issue
Closed
opened 2024-02-02 09:58:27 +00:00 by Vylpes · 10 comments
Vylpes commented 2024-02-02 09:58:27 +00:00
Owner
Copy link

Epic:
Story Points: 8

AS a user, I want to be able to search for a card by its name
SO THAT I can see a card I might not know its number of

Acceptance Criteria

AS a user
GIVEN I search for a card
WHEN I type /view <name>
AND multiple are found
THEN a list of the cards will be returned

AS a user
GIVEN I search for a card
WHEN I type /view <name>
AND one is found
THEN the single card will be returned

Subtasks

  • Update view command to have a paginated view embeds by the search
  • Fix card pagination going to different cards
  • Fix unable to find cards issue
  • Bring back logic command as /id command
  • Fix the pagination creating a new message each time

Notes

Epic: \ Story Points: 8 --- AS a user, I want to be able to search for a card by its name SO THAT I can see a card I might not know its number of ## Acceptance Criteria AS a user GIVEN I search for a card WHEN I type `/view <name>` AND multiple are found THEN a list of the cards will be returned AS a user GIVEN I search for a card WHEN I type `/view <name>` AND one is found THEN the single card will be returned ## Subtasks - [x] Update view command to have a paginated view embeds by the search - [x] Fix card pagination going to different cards - [x] Fix unable to find cards issue - [x] Bring back logic command as `/id` command - [x] Fix the pagination creating a new message each time ## Notes - https://www.npmjs.com/package/fzf - Command will search and show the view as each individual card, with a next and previous button between them
Vylpes added the
type
story
 label 2024-02-02 09:58:38 +00:00
Vylpes changed title from View command search functionality to AS a user, I want to be able to search for a card by its name 2024-02-04 15:06:14 +00:00
Vylpes commented 2024-02-04 15:09:15 +00:00
Author
Owner
Copy link

Need to investigate how to do the search

Need to investigate how to do the search
Vylpes added the
blocked
 label 2024-02-04 15:09:19 +00:00
Vylpes commented 2024-05-12 15:16:30 +01:00
Author
Owner
Copy link

Blocked by #156

Blocked by #156
Vylpes removed the
blocked
 label 2024-08-08 18:27:44 +01:00
Vylpes commented 2024-08-08 18:28:04 +01:00
Author
Owner
Copy link

Will use this package: https://www.npmjs.com/package/fzf

Will use this package: https://www.npmjs.com/package/fzf
Vylpes added this to the 0.9.0 milestone 2024-08-08 18:29:37 +01:00
Vylpes added this to the 0.9 Sprint 1 project 2024-08-08 18:29:39 +01:00
Vylpes started working 2024-08-10 14:13:55 +01:00
Vylpes commented 2024-08-10 14:52:13 +01:00
Author
Owner
Copy link

Builds but won't start due to error, https://github.com/ajitid/fzf-for-js/issues/124 might help

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/vylpes/projects/card-drop/node_modules/fzf/dist/fzf.umd.js from /home/vylpes/projects/card-drop/dist/helpers/CardSearchHelper.js not supported.
fzf.umd.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead either rename fzf.umd.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in /home/vylpes/projects/card-drop/node_modules/fzf/package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead).
Builds but won't start due to error, https://github.com/ajitid/fzf-for-js/issues/124 might help ``` Error [ERR_REQUIRE_ESM]: require() of ES Module /home/vylpes/projects/card-drop/node_modules/fzf/dist/fzf.umd.js from /home/vylpes/projects/card-drop/dist/helpers/CardSearchHelper.js not supported. fzf.umd.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules. Instead either rename fzf.umd.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in /home/vylpes/projects/card-drop/node_modules/fzf/package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead). ```
Vylpes stopped working 2024-08-10 14:52:22 +01:00
38 minutes 27 seconds
Vylpes modified the project from 0.9 Sprint 1 to 0.9 Sprint 2 2024-08-11 15:10:58 +01:00
Vylpes self-assigned this 2024-08-11 15:11:17 +01:00
Vylpes started working 2024-08-14 18:27:32 +01:00
Vylpes stopped working 2024-08-14 18:49:45 +01:00
22 minutes 13 seconds
Vylpes commented 2024-08-14 22:27:07 +01:00
Author
Owner
Copy link

Need to test tomorrow

Need to test tomorrow
Vylpes started working 2024-08-16 17:48:41 +01:00
Vylpes commented 2024-08-16 17:59:06 +01:00
Author
Owner
Copy link

I need to find a new package, I can't get this one working for some reason

I need to find a new package, I can't get this one working for some reason
Vylpes commented 2024-08-16 18:01:25 +01:00
Author
Owner
Copy link

Trying out https://www.npmjs.com/package/fuse.js

Trying out https://www.npmjs.com/package/fuse.js
Vylpes stopped working 2024-08-16 18:41:06 +01:00
52 minutes 25 seconds
VylpesTester added spent time 2024-08-17 17:26:24 +01:00
5 minutes
Vylpes commented 2024-08-17 19:02:42 +01:00
Author
Owner
Copy link

Test has failed, if you press next then previous again it generates a different card. A fix might be to hard code only top 5, and pass each one into the custom id at the start

Test has failed, if you press next then previous again it generates a different card. A fix might be to hard code only top 5, and pass each one into the custom id at the start
Vylpes started working 2024-08-21 18:35:05 +01:00
Vylpes stopped working 2024-08-21 19:03:09 +01:00
28 minutes 4 seconds
Vylpes started working 2024-08-23 17:54:38 +01:00
Vylpes stopped working 2024-08-23 18:28:34 +01:00
33 minutes 56 seconds
Vylpes started working 2024-08-24 16:04:06 +01:00
Vylpes stopped working 2024-08-24 16:10:14 +01:00
6 minutes 8 seconds
VylpesTester added spent time 2024-08-24 17:26:14 +01:00
5 minutes
VylpesTester commented 2024-08-24 18:29:52 +01:00
Member
Copy link

This has failed testing, the pagination creates a new message instead of updating the old one

This has failed testing, the pagination creates a new message instead of updating the old one
VylpesTester added spent time 2024-08-24 18:30:36 +01:00
4 minutes
Vylpes modified the project from 0.9 Sprint 2 to 0.9 Sprint 3 2024-08-25 15:04:47 +01:00
Vylpes started working 2024-08-26 18:09:57 +01:00
Vylpes canceled time tracking 2024-08-26 18:11:23 +01:00
Vylpes commented 2024-08-26 18:12:03 +01:00
Author
Owner
Copy link

Seems to have fixed itself

Seems to have fixed itself
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feature/380-use-effect
develop
renovate/typescript-eslint-parser-8.x-lockfile
renovate/typescript-eslint-eslint-plugin-8.x-lockfile
renovate/express-4.x-lockfile
renovate/dotenv-16.x-lockfile
renovate/typescript-5.x-lockfile
renovate/np-10.x-lockfile
renovate/eslint-9.x-lockfile
renovate/node-22.x-lockfile
renovate/cron-3.x-lockfile
renovate/appleboy-ssh-action-1.x
release/0.9.0
renovate/node-20.x-lockfile
renovate/jest-29.x-lockfile
hotfix/0.8.2
renovate/discord.js-14.x-lockfile
v0.8.2
v0.8.1
v0.8.0
v0.7.0
v0.6.4
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.2
v0.5.1
v0.5.0
v0.4.2
v0.4.1
v0.4.0
v0.3.1
v0.3.0
v0.2.1
v0.2.0
v0.1.8
v0.1.7
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
needs tests

   
question

   
requires documentation
  
type
admin

  
type
alert

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
needs criteria
needs estimate
needs tests
question
requires documentation
type
admin
type
alert
type
bug
type
change
type
defect
type
dependencies
type
epic
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
0.9.0
Projects
Clear projects
No items
No project
0.9 Sprint 3
Assignees
Clear assignees
No assignees
Vylpes
2 participants
Notifications
Total time spent: 3 hours 15 minutes
Vylpes
3 hours 1 minute
VylpesTester
14 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#154
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?