External/card-drop
4
0
Fork 0
Code Issues 23 Pull requests 1 Actions Packages Projects 1 Releases 24 Wiki Activity

Add ESLint and fix issues #133

Merged
Vylpes merged 7 commits from feature/49-eslint into develop 2024-01-05 19:26:44 +00:00
Conversation 0 Commits 7 Files changed 44 +1590 -280
Vylpes commented 2024-01-03 18:32:40 +00:00
Owner
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Add ESLint to the project
  • Fix issues which ESLint found

#49

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Add ESLint to the project - Fix issues which ESLint found #49 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 5 commits 2024-01-03 18:32:40 +00:00
Start of eslint fix
Some checks failed
continuous-integration/drone/push Build is failing
Details
1e16644732
Fix eslint issues
All checks were successful
continuous-integration/drone/push Build is passing
Details
808314701e
Vylpes requested review from VylpesTester 2024-01-03 18:32:44 +00:00
VylpesTester was assigned by Vylpes 2024-01-03 18:32:47 +00:00
Vylpes added the
type
story
 label 2024-01-03 18:32:50 +00:00
Vylpes added 2 commits 2024-01-03 18:56:01 +00:00
Fix double quotes
All checks were successful
continuous-integration/drone/push Build is passing
Details
11b3e6dc91
VylpesTester approved these changes 2024-01-05 19:26:27 +00:00
VylpesTester added spent time 2024-01-05 19:26:30 +00:00
5 minutes
Vylpes merged commit 39529cf20c into develop 2024-01-05 19:26:44 +00:00
Vylpes deleted branch feature/49-eslint 2024-01-05 19:26:44 +00:00
Vylpes referenced this pull request from a commit 2024-01-05 19:26:46 +00:00
Add ESLint and fix issues (#133)
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
blocked

   
duplicate

   
question

   
requires documentation
  
type
admin

  
type
bug

  
type
change

  
type
defect

  
type
dependencies

  
type
epic

  
type
spike

  
type
story

  
type
subtask

  
won't fix
No labels
blocked
duplicate
question
requires documentation
type
admin
type
bug
type
change
type
defect
type
dependencies
type
epic
type
spike
type
story
type
subtask
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Total time spent: 5 minutes
VylpesTester
5 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: External/card-drop#133
No description provided.
Delete branch "feature/49-eslint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?