src/buttonEvents/Multidrop.ts

@@ -98,19 +98,11 @@ export default class Multidrop extends ButtonEvent {
         await interaction.deferUpdate();
 
         try {
-            const files = [];
-            let imageFileName = "";
-
-            if (!(randomCard.card.path.startsWith("http://") || randomCard.card.path.startsWith("https://"))) {
             const image = readFileSync(path.join(process.env.DATA_DIR!, "cards", randomCard.card.path));
-                imageFileName = randomCard.card.path.split("/").pop()!;
+            const imageFileName = randomCard.card.path.split("/").pop()!;
 
             const attachment = new AttachmentBuilder(image, { name: imageFileName });
 
-                files.push(attachment);
-            }
-
-
             const inventory = await Inventory.FetchOneByCardNumberAndUserId(interaction.user.id, randomCard.card.id);
             const quantityClaimed = inventory ? inventory.Quantity : 0;
 
@@ -120,7 +112,7 @@ export default class Multidrop extends ButtonEvent {
 
             await interaction.editReply({
                 embeds: [ embed ],
-                files: files,
+                files: [ attachment ],
                 components: [ row ],
             });
         } catch (e) {

src/commands/multidrop.ts

@@ -62,18 +62,11 @@ export default class Multidrop extends Command {
         await interaction.deferReply();
 
         try {
-            const files = [];
-            let imageFileName = "";
-
-            if (!(randomCard.card.path.startsWith("http://") || randomCard.card.path.startsWith("https://"))) {
             const image = readFileSync(path.join(process.env.DATA_DIR!, "cards", randomCard.card.path));
-                imageFileName = randomCard.card.path.split("/").pop()!;
+            const imageFileName = randomCard.card.path.split("/").pop()!;
 
             const attachment = new AttachmentBuilder(image, { name: imageFileName });
 
-                files.push(attachment);
-            }
-
             const inventory = await Inventory.FetchOneByCardNumberAndUserId(interaction.user.id, randomCard.card.id);
             const quantityClaimed = inventory ? inventory.Quantity : 0;
 
@@ -83,7 +76,7 @@ export default class Multidrop extends Command {
 
             await interaction.editReply({
                 embeds: [ embed ],
-                files: files,
+                files: [ attachment ],
                 components: [ row ],
             });
         } catch (e) {

tests/buttonEvents/Multidrop.test.ts

@@ -1,13 +0,0 @@
-describe("execute", () => {
-    describe("GIVEN randomCard image is hosted locally", () => {
-        test.todo("EXPECT image to be uploaded directly");
-    });
-
-    describe("GIVEN randomCard image is hosted via http", () => {
-        test.todo("EXPECT image link to be directly added to embed");
-    });
-
-    describe("GIVEN randomCard image is hosted via https", () => {
-        test.todo("EXPECT image link to be directly added to embed");
-    });
-});

tests/commands/multidrop.test.ts

@@ -1,13 +0,0 @@
-describe("execute", () => {
-    describe("GIVEN randomCard image is hosted locally", () => {
-        test.todo("EXPECT image to be uploaded directly");
-    });
-
-    describe("GIVEN randomCard image is hosted via http", () => {
-        test.todo("EXPECT image link to be directly added to embed");
-    });
-
-    describe("GIVEN randomCard image is hosted via https", () => {
-        test.todo("EXPECT image link to be directly added to embed");
-    });
-});