From 7c9411b4e290b7686dbbf445d52f983b34a1a30a Mon Sep 17 00:00:00 2001 From: Ethan Lane Date: Fri, 26 Jul 2024 18:17:21 +0100 Subject: [PATCH 1/3] Fix deprecated toBeCalledWith function call (#195) - Remove the missed deprecated `toBeCalledWith` function call and replaced with `toHaveBeenCalledWith` - There should now no longer be any deprecated functions #138 Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/195 Reviewed-by: VylpesTester Co-authored-by: Ethan Lane Co-committed-by: Ethan Lane --- tests/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/index.test.ts b/tests/index.test.ts index ffa9015..874f129 100644 --- a/tests/index.test.ts +++ b/tests/index.test.ts @@ -122,7 +122,7 @@ describe('randomBunny', () => { expect(result.Error!.Code).toBe(ErrorCode.NoImageResultsFound); expect(result.Error!.Message).toBe(ErrorMessages.NoImageResultsFound); - expect(fetchMock).toBeCalledWith('https://reddit.com/r/rabbits/new.json?limit=100'); + expect(fetchMock).toHaveBeenCalledWith('https://reddit.com/r/rabbits/new.json?limit=100'); }); test('GIVEN randomSelect does NOT find a valid response, EXPECT failure result', async () => { From 56c886862cef8dd8cdc76ae460a98d26c5a2685c Mon Sep 17 00:00:00 2001 From: Ethan Lane Date: Fri, 26 Jul 2024 18:18:43 +0100 Subject: [PATCH 2/3] Add a newline character to the output of a file (#196) - Add a newline character at the end of the outputted file contents - This is so it follows POSIX convention #80 Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/196 Reviewed-by: VylpesTester Co-authored-by: Ethan Lane Co-committed-by: Ethan Lane --- src/helpers/cliHelper.ts | 2 +- tests/helpers/cliHelper.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/helpers/cliHelper.ts b/src/helpers/cliHelper.ts index 2776f2e..f4f5c63 100644 --- a/src/helpers/cliHelper.ts +++ b/src/helpers/cliHelper.ts @@ -9,7 +9,7 @@ export default class CliHelper { const output = OutputHelper.GenerateOutput(response, options); if (options.o) { - writeFileSync(options.o, output); + writeFileSync(options.o, `${output}\n`); } else { console.log(output); } diff --git a/tests/helpers/cliHelper.test.ts b/tests/helpers/cliHelper.test.ts index 3ea6687..0deb946 100644 --- a/tests/helpers/cliHelper.test.ts +++ b/tests/helpers/cliHelper.test.ts @@ -35,7 +35,7 @@ describe("Endpoint", () => { expect(OutputHelper.GenerateOutput).toHaveBeenCalledWith(response, options); expect(fs.writeFileSync).toHaveBeenCalledTimes(1); - expect(fs.writeFileSync).toHaveBeenCalledWith("file.txt", "test output"); + expect(fs.writeFileSync).toHaveBeenCalledWith("file.txt", "test output\n"); expect(console.log).not.toHaveBeenCalled(); From c13f6818a7570b657aa9cff5e9aa90301587c5be Mon Sep 17 00:00:00 2001 From: Ethan Lane Date: Wed, 24 Jul 2024 17:25:48 +0100 Subject: [PATCH 3/3] Add type/dependency label to renovate config --- renovate.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/renovate.json b/renovate.json index 1116f5a..fa57fba 100644 --- a/renovate.json +++ b/renovate.json @@ -1,4 +1,5 @@ { "$schema": "https://docs.renovatebot.com/renovate-schema.json", - "baseBranches": ["develop"] + "baseBranches": ["develop"], + "labels": ["type/dependencies"] }